[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-bugs] #20764 [Core Tor/Tor]: Duplicate memset call in tor_addr_from_sockaddr



#20764: Duplicate memset call in tor_addr_from_sockaddr
--------------------------------+-----------------
     Reporter:  icanhasaccount  |      Owner:
         Type:  defect          |     Status:  new
     Priority:  Very Low        |  Milestone:
    Component:  Core Tor/Tor    |    Version:
     Severity:  Trivial         |   Keywords:
Actual Points:                  |  Parent ID:
       Points:                  |   Reviewer:
      Sponsor:                  |
--------------------------------+-----------------
 Hey folks,

 I hope that you're all doing well and life is good!

 When staring grumpily at bug
 https://trac.torproject.org/projects/tor/ticket/20716 I noticed that
 memset(addr, 0,...) is called on the address in tor_addr_from_sockaddr and
 then again in either tor_addr_from_ipv4n, tor_addr_from_ipv6_bytes,
 tor_addr_make_af_unix or      tor_addr_make_unspec.

 The attached removes the memset call from tor_addr_from_sockaddr.

 Thanks in advance for perusal :)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20764>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs