[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #21145 [Metrics/ExoneraTor]: Adapt ExoneraTor to using metrics-base



#21145: Adapt ExoneraTor to using metrics-base
--------------------------------+------------------------------
 Reporter:  iwakeh              |          Owner:  iwakeh
     Type:  enhancement         |         Status:  needs_review
 Priority:  Medium              |      Milestone:
Component:  Metrics/ExoneraTor  |        Version:
 Severity:  Normal              |     Resolution:
 Keywords:  metrics-2017        |  Actual Points:
Parent ID:                      |         Points:
 Reviewer:                      |        Sponsor:
--------------------------------+------------------------------
Changes (by iwakeh):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:8 karsten]:
 > Hmm, the patch looks good, but I'm having trouble executing the JAR
 file:
 >
 > [snip]
 >
 > Any idea what could be missing?

 Please find a [https://gitweb.torproject.org/user/iwakeh/metrics-
 base.git/commit/?h=task-21145 commit in metrics-base] and a
 [https://gitweb.torproject.org/user/iwakeh/exonerator.git/commit/?h=task-21145&id=457fd1c8931e2eb6b79ef38ccde9ca9ac519ce1e
 fixup commit] for the build.xml on top of my patch branch.
 The jdbc jar and its service definition were missing.

 >
 > (Minor nitpick: let's also remove the `run-exonerator.sh` file in this
 change. I can do that when merging the branch.)

 No nitpick,  I overlooked removing this file, which is part of a
 [https://gitweb.torproject.org/user/iwakeh/exonerator.git/commit/?h=task-21145&id=e91a28464d7b7f07b3487fce36918dc6b5fa26f6
 second fixup commit].

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21145#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs