[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #2001 [Tor Relay]: Reachability test for ORPort doesn't complete with --enable-bufferevents set

#2001: Reachability test for ORPort doesn't complete with --enable-bufferevents
set
-----------------------+----------------------------------------------------
 Reporter:  Sebastian  |       Owner:  nickm   
     Type:  defect     |      Status:  accepted
 Priority:  normal     |   Milestone:          
Component:  Tor Relay  |     Version:          
 Keywords:             |      Parent:          
-----------------------+----------------------------------------------------

Comment(by nickm):

 Indeed, we aren't generating END cells on linked connections.  The only
 way to get an BEV_EVENT_EOF out of a bufferevent_pair is to call
 bufferevent_flush on it, and the only way to get
 connection_edge_reached_eof() called with bufferevents is by generating a
 BEV_EVENT_EOF.

 Arguably, libevent's bufferevent pairs should also generate a
 BEV_EVENT_EOF when BEV_OPT_CLOSE_ON_FREE is set on them, and you free the
 other one of them.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2001#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs