[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #9948 [Tor]: Configure should error if libssp is not installed



#9948: Configure should error if libssp is not installed
-------------------------+--------------------------------
     Reporter:  huslage  |      Owner:
         Type:  defect   |     Status:  new
     Priority:  normal   |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor      |    Version:  Tor: 0.2.4.17-rc
   Resolution:           |   Keywords:  tor-client build
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+--------------------------------
Changes (by nickm):

 * keywords:   => tor-client build
 * milestone:   => Tor: 0.2.5.x-final


Comment:

 copypasted with permission from IRC:
 {{{
 10:35 < sqrt2> nickm: do you want me to attach a patch to #9948 or is that
                unnecessarily bureaucratic?
 10:37 < nickm> sqrt2: A patch would be cool, but there's one thing I'm
 worried
                about.
 10:38 < nickm> sqrt2: If we just change AC_TRY_COMPILE to AC_TRY_LINK in
 that
                macro, then we won't get the desired effect ("give an error
 when
                --enable-gcc-hardening is on, but libssp is needed and
 absent.")
                Instead, we will decide that we can't turn on ssp, because
                linking didn't work.
 10:38 < nickm> So we'll need to make sure that if the ssp option makes us
                compile but not link, we give an error
 10:38 < sqrt2> well, technically, we can't turn on ssp, and
                --enable-gcc-hardening is a default, not something the user
                explicitly wanted
 10:39 < sqrt2> but it may be a good idea to force the user to disable it
                manually nevertheless
 10:39 < nickm> right.
 10:44 < sqrt2> nickm: i'll try to get my hands on a build environment that
 has
                such a libc and hopefully just test out the methods then
 }}}

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9948#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs