[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #13324 [Tor Browser]: Generation of incremental MAR files



#13324: Generation of incremental MAR files
-----------------------------+----------------------------------
     Reporter:  boklm        |      Owner:  tbb-team
         Type:  task         |     Status:  needs_review
     Priority:  normal       |  Milestone:
    Component:  Tor Browser  |    Version:
   Resolution:               |   Keywords:  TorBrowserTeam201410
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+----------------------------------

Comment (by boklm):

 Replying to [comment:2 mcs]:
 > Thanks for doing this.  Kathy Brade and I reviewed your changes and
 everything looks OK to us (note that we are not Perl experts).  Nice work!

 Thanks for reviewing this.

 > You might consider adding a -q parameter when you exec
 make_incremental_update.sh (unless you think you need it for debugging).
 We added support for -q because the Mozilla scripts are very chatty.

 We are not displaying the output of the script, so it's not a problem that
 it is chatty.

 >
 > I think we need a make target that runs the update_responses program and
 then verifies against other developers' builds (to check reproducibility).

 Yes. The new MAR files are added to the gitian/$version directory, so
 running hash-bundles.sh again should update the sha256sums.txt with the
 new files. However, it will add a mismatch with other developers who did
 not generate the incremental MAR files, so I'm wondering if it would be
 better to add them to a separate sha256sums file.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13324#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs