Re: [tor-bugs] #12967 [Tor Launcher]: Support a multi-lingual TBB that can switch between localizations

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#12967: Support a multi-lingual TBB that can switch between localizations
-------------------------------------------------+-------------------------
 Reporter:  mikeperry                            |          Owner:  mcs
     Type:  enhancement                          |         Status:
 Priority:  High                                 |  needs_revision
Component:  Tor Launcher                         |      Milestone:
 Severity:  Normal                               |        Version:
 Keywords:  tbb-usability-stopppoint-wizard,     |     Resolution:
  TorBrowserTeam201510R                          |  Actual Points:
Parent ID:  #17304                               |         Points:
  Sponsor:  SponsorU                             |
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => needs_revision
 * severity:   => Normal


Comment:

 Replying to [comment:18 mcs]:
 > The changes for part 1 (Tor Launcher) are available here:
 > https://gitweb.torproject.org/user/brade/tor-
 launcher.git/commit/?h=bug12967-01&id=6125fd9230ce1bd542fd502dcc25cbc3a15782a1
 >
 > Next, we will work on the bundling changes (in builders/tor-browser-
 bundle).

 Overall, this looks good. Comments:

 1) Please use "locale" in the lang strings as well instead of "local".
 This is error-prone otherwise.

 2) If I test your changes on a non-english system (in this case a german
 one) the "Quit" button and the "Next" button are shown using different
 locales (the former is translated the latter in english) which is
 confusing.

 3) While it seems my non-en locale is detected the selected language on
 the wizard is english, though.
 It seemed to me, while reading `initLocaleDialog()`, it should be
 "Deutsch" in my case.

 4)

 {{{
 +<?xml-stylesheet href="chrome://global/skin/" type="text/css"?>
 }}}

 has a superfluous whitespace at the end.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12967#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs