[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #20077 [Core Tor/Tor]: Make is_sensitive_dir_purpose and purpose_needs_anonymity consistent



#20077: Make is_sensitive_dir_purpose and purpose_needs_anonymity consistent
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.0.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  refactor, 030-proposed,              |  Actual Points:
  TorCoreTeam201610                              |
Parent ID:                                       |         Points:  1
 Reviewer:  teor                                 |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by chelseakomlo):

 Hey! It isn't clear what cases should be tested for router_purpose in
 purpose_needs_anonymity.

 In the previous code, purpose_needs_anonymity returned true by default,
 and the only router_purpose case that was tested would return also true.
 So removing this case doesn't (from what I can see!) change the logic
 flow.

 See here:
 https://github.com/chelseakomlo/tor_patches/commit/c6d0255eebdafe7b635c6c762c8c16a5a45b5a2f
 #diff-c56fd972333216da3bb1852bcc89f57dL131

 Are there a list of cases where a router_purpose should _not_ use an
 anonymous connection?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20077#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs