[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #18873 [Core Tor/Tor]: Refactor circuit_predict_and_launch_new()
#18873: Refactor circuit_predict_and_launch_new()
--------------------------+------------------------------------
Reporter: asn | Owner:
Type: defect | Status: needs_review
Priority: Low | Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: refactoring | Actual Points:
Parent ID: | Points:
Reviewer: dgoulet | Sponsor:
--------------------------+------------------------------------
Comment (by chelseakomlo):
Ok, great, that is good everything checks out for that refactor, thanks!
Let me know if you have further recommendations for better naming or
anything else that can be extracted from circuit_predict_and_launch_new. I
can look at adding more unit tests, to needs_hs_client_circuits and
circuit_predict_and_launch_new as well.
I can help with investigating how the behavior could be improved, but it
would be good to get some ideas on how to start. I.e, what constitutes
better/worse behavior.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18873#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs