[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #23573 [Core Tor/Tor]: Do we want to close all connections when tor closes?
#23573: Do we want to close all connections when tor closes?
-------------------------------------------------+-------------------------
Reporter: teor | Owner: teor
Type: enhancement | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.3.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: shutdown, privcount, correctness, | Actual Points:
chutney-wants, review-group-24 |
Parent ID: | Points: 0.5
Reviewer: | Sponsor:
| Sponsor8
-------------------------------------------------+-------------------------
Changes (by nickm):
* status: needs_review => needs_revision
Comment:
Needs a changes file.
I'd rather have a real fix for #23570 than the sleep() call here, if at
all possible.
Maybe we should just fflush() everything?
I think that rather than having main.c call hibernate_go_dormant, we
should extract the relevant part of hibernate_go_dormant into a new
function, and have main.c call that.
Is the connection_mark_for_close() in hibernate_go_dormant enough here?
It only marks the connections; it doesn't necessarily close them.
The commit message says `Implements #435`, but I don't think that's right?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23573#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs