[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #27741 [Core Tor/Tor]: too many arguments in rust protover_compute_vote()
#27741: too many arguments in rust protover_compute_vote()
-------------------------------------------------+-------------------------
Reporter: cyberpunks | Owner: nickm
Type: defect | Status:
| needs_revision
Priority: Very High | Milestone: Tor:
| 0.3.5.x-final
Component: Core Tor/Tor | Version: Tor:
| 0.3.3.6
Severity: Normal | Resolution:
Keywords: 035-must, protover, memory-safety, | Actual Points:
033-backport, 034-backport |
Parent ID: #27739 | Points:
Reviewer: teor | Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):
* status: needs_review => needs_revision
Comment:
Replying to [comment:18 cyberpunks]:
> Replying to [comment:16 teor]:
> > We only applied rustfmt in 0.3.5,
>
> That's true. Though we might as well try to follow the rustfmt rules for
the commits merged to maint-0.3.3 too, right? If we introduce new style
differences between the branches that weren't there before, future fixes
to adjacent code will have unnecessary merge conflicts.
It's nickm's code, so I'm going to let him decide if he wants to copy the
rustfmt changes from 0.3.5 to 0.3.3.
> Also, this ticket is missing the `rust` tag.
Fixed!
nickm, if you're happy with the branches as-is, please merge:
* https://github.com/torproject/tor/pull/346 to 0.3.3 and later
* https://github.com/torproject/tor/pull/431 to 0.3.5 and later
If you decide to copy the rustfmt changes from 0.3.5 to 0.3.3, I can do a
quick review.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27741#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs