[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #31958 [Core Tor/Tor]: connection_dir_is_anonymous: Non-fatal assertion !(CONST_TO_OR_CIRCUIT(circ)->p_chan == NULL) failed
#31958: connection_dir_is_anonymous: Non-fatal assertion
!(CONST_TO_OR_CIRCUIT(circ)->p_chan == NULL) failed
----------------------------------+------------------------------------
Reporter: dgoulet | Owner: dgoulet
Type: defect | Status: accepted
Priority: Medium | Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: regression, 042-must | Actual Points:
Parent ID: #30344 | Points:
Reviewer: | Sponsor: Sponsor27-must
----------------------------------+------------------------------------
Changes (by dgoulet):
* owner: (none) => dgoulet
* status: new => accepted
Comment:
Replying to [comment:1 teor]:
> It could be #30344?
Could be!
> The channel is closed, but the command is still being processed?
Actually, yes that is possible that the channel was closed and thus
leading to the `p_chan` to be NULL.
And if we can start reading on a closed connection, we might end up in
that code path.
An approach here could be to test #30344 once merged and see if this
happens again. On two relays I operate, I saw this assert() in few hours
so over couple days of running the patch, I think we'll be sure that we
fixed it.
Not sure we can easily unit test this with the whole connection "start
reading" code complexity :S.
I'll take ownership of this and test #30344 fix in production.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31958#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs