[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32103 [Core Tor/Tor]: Subsystem "thread_cleanup" is never called

#32103: Subsystem "thread_cleanup" is never called
--------------------------------------+------------------------------------
 Reporter:  opara                     |          Owner:  (none)
     Type:  defect                    |         Status:  needs_revision
 Priority:  Medium                    |      Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor              |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  042-should, extra-review  |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:  nickm                     |        Sponsor:
--------------------------------------+------------------------------------

Comment (by opara):

 Thanks for the review. If you want to call `subsystems_thread_cleanup()`
 from `spawn_exit()`, then I think it's best to close this PR, and make a
 new patch that does that instead since none of this code will be needed.
 The problem is that it make linking complicated, since now you need to
 link the tor code from `app/` into the tools in `src/tools`, or to remove
 the `lib/thread` code from these tools. I'm not sure the best way to do
 this, so I'll let someone else who is more familiar with the tor build
 system take a look at this.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32103#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs