[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #1613 [BridgeDB]: i18n bridgedb



#1613: i18n bridgedb
----------------------+-----------------------------------------------------
 Reporter:  phobos    |       Owner:  kaner                    
     Type:  task      |      Status:  needs_review             
 Priority:  normal    |   Milestone:  BridgeDB Upgrades Phase 1
Component:  BridgeDB  |     Version:                           
 Keywords:            |      Parent:                           
----------------------+-----------------------------------------------------

Comment(by kaner):

 Replying to [comment:8 nickm]:

 Thanks for your comment.

 > 1)  a and b could be solved by having enabled/disabled be somehow
 attached to the languages themselves.  I don't know our pootle process
 that well.  It does seem, though, that trying to edit the configuration
 file to tell which languages are up-to-date is a bit of a losing
 proposition.  Is there really no way to get only the translated languages?

 Ok, I just got rid of that whole bit. We now try our best to find a
 translation, if there is none, we fall back to english. No looping through
 the filesystem, no config file editing.

 > 2) A list beats a bunch of indexed variables.  Lists are naturally
 iterable, joinable, resizeable, etc, whereas if you add or remove an entry
 from the bunch of indexed variables, you've got to change everything that
 uses them.

 Accepted, changed.

 Also, 3) from your original comment is changed: No global Translation
 objects anymore.

 The code is tested (https, email requests for different languages), pylint
 was run, the install procedure and README are adapted.

 Please review and merge if possible.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1613#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs