[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #1772 [Tor Client]: Counting circuit timeouts when we can't establish any TLS connection
#1772: Counting circuit timeouts when we can't establish any TLS connection
------------------------+---------------------------------------------------
Reporter: arma | Owner: mikeperry
Type: defect | Status: needs_review
Priority: major | Milestone: Tor: 0.2.2.x-final
Component: Tor Client | Version:
Keywords: | Parent:
------------------------+---------------------------------------------------
Changes (by mikeperry):
* status: assigned => needs_review
Comment:
I decided to simplify all this code. We now consider the network down if
we see no cells for the duration of one full circuit measurement period.
Fixes in mikeperry/bug1772.
Re your B: If the close_ms == timeout_ms, it shouldn't cause any *extra*
timeouts, right? Either way, the circuit would get closed and a new one
would have to be launched.. Also, gcc doesn't like == or != comparisons
for floating point values, and it will warn if I do that...
Re D: The cap is a good idea. In that branch, I implemented the timeout_ms
cap to be the largest build time we have observed, and the close_ms cap to
be twice that.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1772#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs