[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #2553 [Tor Hidden Services]: tor2web mode for accessing hidden services



#2553: tor2web mode for accessing hidden services
---------------------------------+------------------------------------------
 Reporter:  arma                 |          Owner:  rransom     
     Type:  enhancement          |         Status:  needs_review
 Priority:  normal               |      Milestone:              
Component:  Tor Hidden Services  |        Version:              
 Keywords:                       |         Parent:  #2552       
   Points:                       |   Actualpoints:              
---------------------------------+------------------------------------------

Comment(by nickm):

 I think I like it!

 Some code issues you shouldn't have to fix:
   * I find the more complicated asserts hard to read.  I'll refactor them
 if we merge, though; my confusion is my own problem.
   * directory_initiate_command_routerstatus_rend()'s interface  sure is
 hideous, isn't it? We should do something about that.  Not a problem
 introduced by this patch, though.

 Also, the security implications of having a "don't be anonymous" mode
 worry me some.  Can we do more to make sure that no user ever thinks that
 turning this on is a good idea?  The check in
 connection_ap_rewrite_and_attach is a good start, but I worry about
 accidentally breaking it later.  Can we have this whole feature be
 disabled unless the user supplies a compile-time option, for instance?
 (Is there any reason not to do that?)

 Also, have the tor2web people tried this out?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2553#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs