[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #10984 [meek]: PHP relay for meek



#10984: PHP relay for meek
-------------------------+----------------------
     Reporter:  arlolra  |      Owner:  dcf
         Type:  defect   |     Status:  accepted
     Priority:  normal   |  Milestone:
    Component:  meek     |    Version:
   Resolution:           |   Keywords:  meek
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+----------------------
Changes (by dcf):

 * status:  needs_revision => accepted


Comment:

 Great work! It works for me. Please commit it.

 It seems to work without this line:
 {{{
 header("Content-Type:text/plain; charset=utf-8");
 }}}
 Let's remove that line, even though without it PHP seems to be sniffing
 text/html. We'd be better off whitelisting response headers with
 CURLOPT_HEADERFUNCTION like before. Otherwise we're claiming "UTF-8" even
 for our POST responses, which doesn't seem to hurt anything but is weird.

 Add a little note about the php directory to the main README file.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10984#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs