[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #17074 [Tor]: Improve coverage on src/common/address.c

#17074: Improve coverage on src/common/address.c
-----------------------------+----------------------------
     Reporter:  rjunior      |      Owner:
         Type:  enhancement  |     Status:  needs_revision
     Priority:  normal       |  Milestone:
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:  testing
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+----------------------------
Changes (by rl1987):

 * status:  needs_review => needs_revision


Comment:

 You are setting a single byte in one address representation, perform a
 conversion and checking if that single byte is available in another
 representation. It would be better if you checked if the entire address is
 the same before and after the conversion.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17074#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs