[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #17085 [Tor]: Improve coverage on src/common/util_process.c

#17085: Improve coverage on src/common/util_process.c
-----------------------------+--------------------------------
     Reporter:  rjunior      |      Owner:
         Type:  enhancement  |     Status:  needs_revision
     Priority:  normal       |  Milestone:  Tor: 0.2.8.x-final
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:  testing
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------------
Changes (by rl1987):

 * status:  needs_review => needs_revision


Comment:

 YourÂ`test_util_process_clear_waitpid_callback()` does not seem to
 checking for anything, unless you consider not crashing to be success. For
 some reason it calls `clear_waitpid_callback()` twice. Since you have some
 log capturing setup ready, maybe you should add some log statements to
 `clear_waitpid_callback()` and look for corresponding entries in the log
 to infer success/failure of `clear_waitpid_callback()` function.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17085#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs