[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #22430 [Core Tor/Chutney]: Add next gen HS support to chutney



#22430: Add next gen HS support to chutney
------------------------------------+--------------------------------
 Reporter:  asn                     |          Owner:  teor
     Type:  enhancement             |         Status:  needs_revision
 Priority:  Medium                  |      Milestone:
Component:  Core Tor/Chutney        |        Version:
 Severity:  Normal                  |     Resolution:
 Keywords:  tor-hs prop224 chutney  |  Actual Points:
Parent ID:                          |         Points:  1
 Reviewer:  teor                    |        Sponsor:
------------------------------------+--------------------------------
Changes (by teor):

 * status:  needs_review => needs_revision
 * reviewer:   => teor
 * points:   => 1


Comment:

 These lines in torrc_templates/hs-v3.tmpl are redundant, because they are
 already in hs.tmpl:
 {{{
 ${include:common.i}
 SocksPort 0
 Address $ip

 }}}

 I think torrc_templates/single-onion-v3.tmpl can become:
 {{{
 ${include:single-onion.tmpl}
 ${include:hs-v3.tmpl}
 }}}

 Nitpicks:
 networks/hs-v3 should have a newline at the end of the file

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22430#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs