[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #23228 [Applications/Tor Browser]: Build a Windows 64 toolchain based on mingw-w64



#23228: Build a Windows 64 toolchain based on mingw-w64
-------------------------------------------+-------------------------------
 Reporter:  boklm                          |          Owner:  tbb-team
     Type:  task                           |         Status:
                                           |  needs_revision
 Priority:  Medium                         |      Milestone:
Component:  Applications/Tor Browser       |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201709  |  Actual Points:
Parent ID:  #20636                         |         Points:
 Reviewer:                                 |        Sponsor:
-------------------------------------------+-------------------------------

Comment (by gk):

 Replying to [comment:12 boklm]:
 > The patch adding the flag back:
 > https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_20636_v6&id=90c730d131d3e003ff626ed613f37c43ada0cb7e
 >
 > And the build with the patch and the flag:
 > https://people.torproject.org/~boklm/tmp/bug_23228/with-
 patch/tor-0.3.1.5-alpha-windows-x86_64-3eb3d4/tor-
 win32-0.3.1.5-alpha.zip.asc
 > https://people.torproject.org/~boklm/tmp/bug_23228/with-
 patch/tor-0.3.1.5-alpha-windows-x86_64-3eb3d4/tor-win32-0.3.1.5-alpha.zip

 Looks better. The `ImageBase` address changes for me on different
 restarts, so, yay! You can test that yourself with e.g. ProcessExplorer
 (opening the lower pane and there should be a column for the addresses).
 The .exe without the patch has 0x400000 as `ImageBase` address.

 This might need more testing, I guess, and someone familiar with
 `binutils` to look over the changes.
 Not finding anyone to do so should at least not block nightly builds with
 the new toolchain.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23228#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs