[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #23568 [Core Tor/Tor]: [PATCH] fix format issues in zstd code on 32 bit

#23568: [PATCH] fix format issues in zstd code on 32 bit
----------------------------+------------------------------------
 Reporter:  andreasstieger  |          Owner:  (none)
     Type:  defect          |         Status:  needs_revision
 Priority:  Medium          |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor    |        Version:  Tor: 0.3.1.7
 Severity:  Normal          |     Resolution:
 Keywords:  zstd            |  Actual Points:
Parent ID:                  |         Points:
 Reviewer:  ahf             |        Sponsor:
----------------------------+------------------------------------
Changes (by ahf):

 * status:  needs_review => needs_revision


Comment:

 Hello!

 Thanks for the patch! Since `%zu` isn't portable across all the platforms
 we support I'd suggest that we change the format string to use `%d`
 instead and cast the parameters to `int`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23568#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs