[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #23583 [Core Tor/Tor]: ext/timeouts/timeout-bitops.c:234: bad shift

#23583: ext/timeouts/timeout-bitops.c:234: bad shift
---------------------------------------+-----------------------------------
 Reporter:  dcb314@…                   |          Owner:  nickm
     Type:  defect                     |         Status:  merge_ready
 Priority:  Medium                     |      Milestone:  Tor:
                                       |  0.3.2.x-final
Component:  Core Tor/Tor               |        Version:
 Severity:  Normal                     |     Resolution:
 Keywords:  030-backport 029-backport  |  Actual Points:
Parent ID:                             |         Points:
 Reviewer:                             |        Sponsor:
---------------------------------------+-----------------------------------

Comment (by nickm):

 > I think I slightly prefer x = (uint64_t)1 << i but not strongly.

 I can never remember whether the order of operations works with that one,
 or whether I need to say `((uint64_t)1)` :)

 Merging.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23583#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs