[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #23653 [Core Tor/Tor]: When accessing onion service with no fetchable descriptor, Tor sits around until timeout rather than hanging up
#23653: When accessing onion service with no fetchable descriptor, Tor sits around
until timeout rather than hanging up
--------------------------+------------------------------------
Reporter: arma | Owner: (none)
Type: defect | Status: new
Priority: Medium | Milestone:
Component: Core Tor/Tor | Version: Tor: 0.2.8.2-alpha
Severity: Normal | Resolution:
Keywords: regression | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------+------------------------------------
Comment (by arma):
commit d8b93b3 is where it's at:
{{{
- ret = rend_client_fetch_v2_desc(rend_query, NULL);
- if (ret <= 0) {
- /* Close pending connections on error or if no hsdir can be found. */
- rend_client_desc_trynow(rend_query->onion_address);
- }
+ rend_client_fetch_v2_desc(rend_query, NULL);
+ /* We don't need to look the error code because either on failure or
+ * success, the necessary steps to continue the HS connection will be
+ * triggered once the descriptor arrives or if all fetch failed. */
return;
}}}
Where does the "if all fetch failed" logic kick in?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23653#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs