[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #27441 [Applications/Tor Browser]: Update Debian Image to use Stretch



#27441: Update Debian Image to use Stretch
-------------------------------------------------+-------------------------
 Reporter:  sisbell                              |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, tbb-mobile,                 |  Actual Points:
  TorBrowserTeam201809                           |
Parent ID:  #26693                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by boklm):

 * status:  needs_review => needs_revision
 * keywords:  tbb-rbm, tbb-mobile, TorBrowserTeam201809R => tbb-rbm, tbb-
     mobile, TorBrowserTeam201809


Comment:

 Replying to [comment:2 sisbell]:
 > Commit: !https://github.com/sisbell/tor-browser-
 build/commit/24fc2e3d63ec6fd692b1b405bd2cdaec0f5c4adb

 Some comments about this patch:
 - subject of the commit should be in the format "Bug XXX: description"
 - maybe something like "add support for stretch in debootstrap-image" is
 more clear than "Update Debian Image to use Stretch"
 - it seems there is a `18.04.1` ubuntu release, so maybe we should use
 that instead of `18.04`.

 Otherwise this looks good. Before merging this we should also check that
 changing the ubuntu version does not break generation of the other debian
 images (for instance by trying to do a full build of Tor Browser for
 Windows/Linux/macOS with this patch).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27441#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs