[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #26871 [Core Tor/Tor]: prop289: randomize the unused part of relay payloads



#26871: prop289: randomize the unused part of relay payloads
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  dgoulet
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.6.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  prop289, 035-roadmap-master, 035     |  Actual Points:
  -triaged-in-20180711, prop289-assigned-        |
  sponsor-v                                      |
Parent ID:  #26288                               |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorV
-------------------------------------------------+-------------------------

Comment (by teor):

 Here are the revisions that are needed:

 Replying to [comment:9 teor]:
 > Replying to [comment:2 arma]:
 > > My {{{task26871}}} branch shows where we would make this change. If we
 like it, it still needs unit tests, changes entry, etc.

 Here are the revisions we probably don't need:

 > > I thought about breaking out the memcpy and the crypto_rand into their
 own function, called something like relay_payload_pack(), but all the
 extra lines didn't seem worth it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26871#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs