[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #27629 [Core Tor/Tor]: add len argument to consensus parsing functions



#27629: add len argument to consensus parsing functions
--------------------------+------------------------------------
 Reporter:  cyberpunks    |          Owner:  (none)
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:  #27244        |         Points:
 Reviewer:                |        Sponsor:  Sponsor8
--------------------------+------------------------------------
Changes (by teor):

 * status:  new => needs_review
 * sponsor:   => Sponsor8
 * milestone:  Tor: 0.3.6.x-final => Tor: 0.3.5.x-final


Comment:

 Thanks for this branch.
 It looks good to me, but I'd like to make sure that CI passes, and that
 someone who is more familiar with this code also does a review.

 Please don't assign tickets to releases, we'll do that based on our
 roadmap for the release.
 (This task is on our roadmap as sponsored work, so we will prioritise
 reviewing it before the feature freeze on Friday.)

 Can you explain the fix in 5d27c458 in the commit message and changes
 file?
 Each fix and feature also gets its own ticket number.
 We usually open a child ticket for each unrelated fix in a branch.

 Or is this change just refactoring?
 For refactoring, the changes file should have the heading:
 Code simplification and refactoring
 https://github.com/torproject/tor/blob/master/scripts/maint/lintChanges.py#L22

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27629#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs