[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #31625 [Core Tor/Tor]: config refactoring: fix hierarchy of configuration variable flags



#31625: config refactoring: fix hierarchy of configuration variable flags
-----------------------------------------+---------------------------------
 Reporter:  nickm                        |          Owner:  nickm
     Type:  defect                       |         Status:  needs_revision
 Priority:  Medium                       |      Milestone:  Tor:
                                         |  0.4.2.x-final
Component:  Core Tor/Tor                 |        Version:
 Severity:  Normal                       |     Resolution:
 Keywords:  network-team-roadmap-august  |  Actual Points:  .8
Parent ID:  #29211                       |         Points:  .5
 Reviewer:  teor                         |        Sponsor:
-----------------------------------------+---------------------------------
Changes (by teor):

 * status:  needs_review => needs_revision
 * actualpoints:  .6 => .8


Comment:

 I couldn't find a branch name or pull request number in the ticket
 comments,
 so I reviewed this pull request:
 * https://github.com/torproject/tor/pull/1296

 Replying to [comment:8 nickm]:
 > The branch is currently divided into these parts:
 >
 > 1. Change the accessor functions in confparse.c so that they correspond
 to the low-level properties that we want to check.
 > {{{
 >       config: replace config_var_is_cumulative with is_replaced_on_set()
 >       config: Invert sense of _is_invisible, and rename to is_listable()
 >       Document config_var_is_dumpable and config_var_is_settable.
 >       config: Introduce the concept of an "ungettable" variable.
 >       config: rename "contained" to "derived", and explain it better.
 >       config: make config_var_is_dumpable static.
 > }}}

 I did a review of this part, I expect to review the other parts tomorrow
 or Thursday (within 48 hours).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31625#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs