[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #31780 [Circumvention/BridgeDB]: Write a specification for BridgeDB's metrics



#31780: Write a specification for BridgeDB's metrics
------------------------------------+-------------------------------
 Reporter:  phw                     |          Owner:  phw
     Type:  task                    |         Status:  needs_review
 Priority:  Medium                  |      Milestone:
Component:  Circumvention/BridgeDB  |        Version:
 Severity:  Normal                  |     Resolution:
 Keywords:                          |  Actual Points:
Parent ID:                          |         Points:  0.5
 Reviewer:  cohosh                  |        Sponsor:  Sponsor30-can
------------------------------------+-------------------------------
Changes (by phw):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:2 cohosh]:
 > I left a few comments on the commit.
 [[br]]
 Thanks! I addressed your feedback
 [https://github.com/NullHypothesis/torspec/compare/8e49989519ca9f38955cc5f240e5c7cb6fb9a7c7...ce028be583a6810fd8866868beea1adf84ee7043
 here].
 [[br]]
 > Also note that the snowflake metrics spec exists in the snowflake
 repository and not in torspec (as suggested in
 https://trac.torproject.org/projects/tor/ticket/28942#comment:65)
 > I know there's already a spec for bridgedb in torspec so appending this
 to that makes sense to me. Just noting the difference here.
 [[br]]
 Good point. BridgeDB's specification is outdated to a point where it may
 do more harm than good and if somebody's interested in the metrics spec,
 they are more likely to search for it in BridgeDB's repo. I think we
 should move it.
 [https://github.com/NullHypothesis/bridgedb/commit/e6908a8f11ad5db24d47b5dccc9ee1368495a404
 Here's a patch] that adds the spec to BridgeDB's repo and updates the code
 to be consistent with the spec. (The spec includes the revisions, so you
 don't have to re-review it.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31780#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs