Re: Property box

[Chema Celorio <chema_gnome@celorio.com>]

I have uploaded a new diff.

Aaron Lehmann wrote:
> 
> Hi, I think you made the diff go in the wrong direction. That is, the diff
> wants to take your version back to the CVS version. Switch the order of
> the directory names to fix this.
> 
> BTW, the best way to send patches it to type 'cvs -z3 diff -u >patch.diff' the
> directory (assumes you checked it out from CVS). That way no backup is
> required. Make sure to run 'cvs -z3 update' before you make the diff!
> 
> I'm looking forward to looking at your changes once the patch is fixed.
> 
> Thanks,
> Aaron Lehmann
> 
> On Tue, 22 Feb 2000, Chema Celorio wrote:
> 
> > Hi everyone.
> >
> > I have uploaded a diff to implement a property box in Dr. Genius.
> > You can find the diff here :
> >
> > http://www.celorio.com/gnome/property_box.diff
> >
> > Here are some issues that I need to let you know about :
> >
> > 1) Please keep in mind that this is my first Linux/GNOME/GTK/Dr-GENIUS
> > code,
> > ( Beer !!!!! ) so any comments will be greatly appreciated. This has
> > been a
> > great learning mini-mini-hack for me.
> >
> > 2) Issues when creating the diff
> >       I could not find a way to eliminate the :
> >       "only in .." messages when I created the diff.
> >       I don't know if this will have any effect when you patch
> >       the code. If it does please let me know and I will
> >       make the diff again.
> >
> >       I made a copy of the directory before coding
> >       and the diff command I used was :
> >       "diff -ru dr-genius/ dr-genius.original/ > property_box.diff"
> >
> > 3) I just implemented one option, just in case you think
> > I need to do something different. After this patch gets
> > committed to the cvs server I will continue with the other
> > options. The option was Calculator/set_max_digits
> >
> > 4) The code was included in drgenius_menus.c which I guess is not
> > the right place to put it. I did not know where this code should be
> > or if this code should be in a file by itself. Because of that, I
> > included
> > the following comments.
> > /* -------- Property box prototypes ----------*/
> > /* --------- END property box proto ....
> > /* -------- Property box variables ----------*/
> > /* --------- END  ....
> > /* -------- Property box code ----------*/
> > /* --------- END  ....
> >
> > so that it can be relocated easily.
> >
> > 5) In order for this to work there has to be a Calculator open, is
> > NOT that it will crash, only that it will not affect the variables.
> > I will work on this latter.
> >
> > Thank You
> > Chema Celorio
> >