Re: Property box

[Aaron Lehmann <aaronl@vitelus.com>]

Don't worry, the diff works. Good work with the dialog. The only problem I
can see is that I'm not sure how well it will work with the MDI model. You
see, there can be unlimited numbers of each type of thing open at the same
time (at least there should be), and each one should probably have
different preferences. So should your dialog be changed so it is used to
set the settings of a particular canvas or figure or calculator, rather
than just global ones?

The answer is that I am not sure. You should talk to George to get the
final word.

Aaron Lehmann

On Tue, 22 Feb 2000, Chema Celorio wrote:

> Ok. I understand now.
> 
> You mean make the diff using the cvs command.!!!
> Yes, I get it now!!
> 
> 
> Do you want me to make the diff with the cvs command
> or can you use the one I made ? If not I will read
> the cvs link you sent me to make the diff again, i 
> will probably uploadit tomorrow, since I HAVE to go
> to bed now.
> 
> About working with the latest code :
> I update my gnome version from the cvs server periodically.
> 
> Thanks Again
> 
> 
> Aaron Lehmann wrote:
> > 
> > Hi,
> > 
> > You don't need a CVS account to work on the CVS version or make diffs.
> > http://developer.gnome.org/tools/cvs.html has instructions for using the
> > GNOME cvs as an anonymous user. The name of the module is dr-genius. You
> > should probably always work on the cvs version even if you don't have an
> > account, becuase otherwise we will have to merge your changes into the CVS
> > version - perhaps manually if anything major has changed since the version
> > you are working on.
> > 
> > Please let me know when you have fixed the diff...
> > 
> > On Tue, 22 Feb 2000, Chema Celorio wrote:
> > 
> > > Thanks Aaron.
> > >
> > > But I do not have a CVS account, I have not asked Miguel for it yet.
> > >
> > >
> > > Aaron Lehmann wrote:
> > > >
> > > > Hi, I think you made the diff go in the wrong direction. That is, the diff
> > > > wants to take your version back to the CVS version. Switch the order of
> > > > the directory names to fix this.
> > > >
> > > > BTW, the best way to send patches it to type 'cvs -z3 diff -u >patch.diff' the
> > > > directory (assumes you checked it out from CVS). That way no backup is
> > > > required. Make sure to run 'cvs -z3 update' before you make the diff!
> > > >
> > > > I'm looking forward to looking at your changes once the patch is fixed.
> > > >
> > > > Thanks,
> > > > Aaron Lehmann
> > > >
> > > > On Tue, 22 Feb 2000, Chema Celorio wrote:
> > > >
> > > > > Hi everyone.
> > > > >
> > > > > I have uploaded a diff to implement a property box in Dr. Genius.
> > > > > You can find the diff here :
> > > > >
> > > > > http://www.celorio.com/gnome/property_box.diff
> > > > >
> > > > > Here are some issues that I need to let you know about :
> > > > >
> > > > > 1) Please keep in mind that this is my first Linux/GNOME/GTK/Dr-GENIUS
> > > > > code,
> > > > > ( Beer !!!!! ) so any comments will be greatly appreciated. This has
> > > > > been a
> > > > > great learning mini-mini-hack for me.
> > > > >
> > > > > 2) Issues when creating the diff
> > > > >       I could not find a way to eliminate the :
> > > > >       "only in .." messages when I created the diff.
> > > > >       I don't know if this will have any effect when you patch
> > > > >       the code. If it does please let me know and I will
> > > > >       make the diff again.
> > > > >
> > > > >       I made a copy of the directory before coding
> > > > >       and the diff command I used was :
> > > > >       "diff -ru dr-genius/ dr-genius.original/ > property_box.diff"
> > > > >
> > > > > 3) I just implemented one option, just in case you think
> > > > > I need to do something different. After this patch gets
> > > > > committed to the cvs server I will continue with the other
> > > > > options. The option was Calculator/set_max_digits
> > > > >
> > > > > 4) The code was included in drgenius_menus.c which I guess is not
> > > > > the right place to put it. I did not know where this code should be
> > > > > or if this code should be in a file by itself. Because of that, I
> > > > > included
> > > > > the following comments.
> > > > > /* -------- Property box prototypes ----------*/
> > > > > /* --------- END property box proto ....
> > > > > /* -------- Property box variables ----------*/
> > > > > /* --------- END  ....
> > > > > /* -------- Property box code ----------*/
> > > > > /* --------- END  ....
> > > > >
> > > > > so that it can be relocated easily.
> > > > >
> > > > > 5) In order for this to work there has to be a Calculator open, is
> > > > > NOT that it will crash, only that it will not affect the variables.
> > > > > I will work on this latter.
> > > > >
> > > > > Thank You
> > > > > Chema Celorio
> > > > >
> > >
>