[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

gEDA-bug: [ geda-Bugs-1452836 ] Gsymcheck: silent fail if file does not exist



Bugs item #1452836, was opened at 2006-03-17 15:43
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=818426&aid=1452836&group_id=161080

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Gsymcheck: silent fail if file does not exist

Initial Comment:
If you feed gsymcheck 20060123 with an invalid
filename, it fails silently giving the impression the
symbol file is correct. The problem lies in the fact
screen logging is turned of at line 93 in gsymcheck.c.

I fixed the problem by adding the following to the code
(starting at line 125):

    if (stat(filename, &buf) != 0) {
      logging_dest = STDOUT_TTY; /* Enable stdout
logging  to give a clear error message if the file
could not be found */
      s_log_message("Could not open [%s]\n", filename);
      s_log_message("Exiting...\n");
      exit(2); /* error */
    } else {

Sorry, no time to make patch, hope the explanation is
clear enough.

Kind regards, 

Hans


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=818426&aid=1452836&group_id=161080
_______________________________________________
geda-bug mailing list
geda-bug@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-bug