[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

gEDA-bug: [ geda-Patches-2989341 ] memory corruption in gschem



Patches item #2989341, was opened at 2010-04-19 14:59
Message generated for change (Tracker Item Submitted) made by rdrehmel
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=818428&aid=2989341&group_id=161080

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Robert Drehmel (rdrehmel)
Assigned to: Nobody/Anonymous (nobody)
Summary: memory corruption in gschem

Initial Comment:
The attached patch fixes memory corruption.

In o_update_component(), g_list_free() is called on the new_attrib list, just after it is merged with the page's attributes via g_list_concat(),
which does *not* copy the list elements.
Needless to say, this caused all kinds of random behaviour and/or segmentation faults.

From the Glib Manual:
"""
g_list_concat()
Adds the second GList onto the end of the first GList. Note that the elements of the second GList are not copied. They are used directly.
"""

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=818428&aid=2989341&group_id=161080


_______________________________________________
geda-bug mailing list
geda-bug@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-bug