[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

gEDA-bug: [Bug 700448] Re: Poor reporting of schematic load errors

Thanks for the patch, Eivind. Unfortunately, at first glance your
changes to the Scheme API are obviously bogus, and I have to NACK this
patch for now.

- You must update the testsuite (probably libgeda/scheme/unit-tests/t0203-page-string-syntax.scm).
- You must update the documentation (docs/scheme-api/geda-scheme.texi).
- You must use an appropriate exception key symbol (i.e. not 'object-state').
- You must use a '~a' or '~s' format specifier (Scheme does not use '%' as the format escape symbol; read the Guile manual entry for 'simple-format').

I also suggest that you split the patch into two: one which updates the
libgeda core, and one which updates the Scheme API with the changes I've
requested above.

These were the issues that immediately leapt out at me; I haven't had
time to look through the rest of the patch yet, but I'll try to find
time to do so later this week.

-- 
You received this bug notification because you are a member of gEDA Bug
Team, which is subscribed to gEDA.
https://bugs.launchpad.net/bugs/700448

Title:
  Poor reporting of schematic load errors

Status in GPL Electronic Design Automation tools:
  Confirmed

Bug description:
  libgeda doesn't signal an error when a schematic or symbol file
  contains invalid syntax, or when any other load error is encountered.

  For example, gnetlist succeeds even when the input schematics
  specified contain unusable garbage.

  Steps to reproduce:

  ÂÂecho GARBAGE > test.sch;
  ÂÂif gnetlist -ggeda test.sch > /dev/null 2>/dev/null
  ÂÂthen
  ÂÂÂÂecho Succeeded
  ÂÂelse
  ÂÂÂÂecho Failed
  ÂÂfi

  Expected output:

  ÂÂFailed

  Actual output:

  ÂÂSucceeded

  Thanks to Peter Clifton for pointing out this problem.

To manage notifications about this bug go to:
https://bugs.launchpad.net/geda/+bug/700448/+subscriptions


_______________________________________________
geda-bug mailing list
geda-bug@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-bug