[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

gEDA-bug: [Bug 901222] Re: Feature - gschem - Dynamic loading of custom symbols in the component selection tree

Hi Luigi,

Thank you for submitting this Scheme function. In order to commit it, I
would appreciate it if you would make the following changes:

* The license for gEDA/gaf is GPLv2+.  Could you please relicense as GPLv2+ instead of GPLv3+?
* The line with "string-trim-right" is not necessary, and prevents you from using directory names that start or end with whitespace (you wouldn't believe some of the things I've seen Windows users do!)
* Please use "substring" instead of "string-copy". This makes it easier to read the code, because it explains what you are doing better. :-)
* We don't use per-file changelogs in gEDA/gaf -- we write useful commit messages for git instead. :-) If this is accepted, the changelog section will need to be removed.

As you are probably aware, we currently have a "component-library-
search" function in libgeda, and this behaves in a very similar way.
What do you think about putting this in as an improved replacement for
"component-library-search", and make the "prefix" argument optional?

  (use-modules (ice-9 optargs))
  
  (define (component-library-search dirname #:optional prefix)
    <body ...> )

Thanks,

Peter

** Changed in: geda
       Status: New => In Progress

** Changed in: geda
   Importance: Undecided => Wishlist

** Tags removed: component gschem symbols tree
** Tags added: libgeda

-- 
You received this bug notification because you are a member of gEDA Bug
Team, which is subscribed to gEDA.
https://bugs.launchpad.net/bugs/901222

Title:
  Feature - gschem - Dynamic loading of custom symbols in the component
  selection tree

Status in GPL Electronic Design Automation tools:
  In Progress

Bug description:
  As attachment a Guile script which extends the (component-library ...) functionality in order to permit to see custom components in the component selection tree grouped by folders. 
  The syntax of the new functionality is as follow:

  into the .gEDA/gafrc file

  (component-library-add-tree "prefix" "symbols/folder")

  The prefix will be added, as a tag, to the folder description.
  Actually the script doesn't manage substitution of the environment
  variables.

  If usefull this script could be added to the main stream.

  Best Regards,
  Luigi

To manage notifications about this bug go to:
https://bugs.launchpad.net/geda/+bug/901222/+subscriptions


_______________________________________________
geda-bug mailing list
geda-bug@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-bug