gEDA-bug: [Bug 901222] Re: Feature - gschem - Dynamic loading of custom symbols in the component selection tree

[Peter TB Brett <901222@xxxxxxxxxxxxxxxxxx>]

Hi Luigi,

This is a good improvement.

I didn't spot the fact you were using the "dirname" function! Perhaps,
to avoid confusion between "dir-name" and "dirname", the argument should
be called "rootdir" or "root"?

You have a couple of places where you have something like:

  (if (eq? #f <expr>) ...)

This is actually equivalent to:

  (if (not <expr>) ...)

and I usually write it as:

  (if <expr> ...)

with the branches swapped.  This makes it easier to read IMHO.

I'm not sure that I agree with your error message. There seem to be two
cases in which an error might get raised:

1) If the root directory passed by the user is not a directory or
missing or inaccessible. Surely, in that case, we *want* a message
dialog to appear, so that they know there is a problem with their
configuration?

2) If there is a problem with one of the files or directories contained
by the root directory, then perhaps it would be best to print a warning
message but skip the directory without raising an error (and causing a
message dialog).

Translatable strings in the Scheme source code is something that I need
to make happen before 1.7.3 can be released.  I have most of the
infrastructure needed already in place; I just need to make sure that
everything uses the correct gettext domains etc.

-- 
You received this bug notification because you are a member of gEDA Bug
Team, which is subscribed to gEDA.
https://bugs.launchpad.net/bugs/901222

Title:
  Feature - gschem - Dynamic loading of custom symbols in the component
  selection tree

Status in GPL Electronic Design Automation tools:
  In Progress

Bug description:
  As attachment a Guile script which extends the (component-library ...) functionality in order to permit to see custom components in the component selection tree grouped by folders. 
  The syntax of the new functionality is as follow:

  into the .gEDA/gafrc file

  (component-library-add-tree "prefix" "symbols/folder")

  The prefix will be added, as a tag, to the folder description.
  Actually the script doesn't manage substitution of the environment
  variables.

  If usefull this script could be added to the main stream.

  Best Regards,
  Luigi

To manage notifications about this bug go to:
https://bugs.launchpad.net/geda/+bug/901222/+subscriptions


_______________________________________________
geda-bug mailing list
geda-bug@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-bug