[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

gEDA-bug: [ geda-Patches-1885313 ] Remove magic index numbers from color scheme config



Patches item #1885313, was opened at 2008-02-02 18:55
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=818428&aid=1885313&group_id=161080

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: gschem
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Tomaz Solc (avian1)
Assigned to: Nobody/Anonymous (nobody)
Summary: Remove magic index numbers from color scheme config

Initial Comment:
Hi

This is a pretty trivial patch that removes an unnecessary "color index" parameter from Scheme functions that are used to set gschem color scheme (for example "background-color"). This parameter was marked in config files as "DO NOT CHANGE", so I see no reason why it should be accessible from there at all.

The value of this parameter is now hard coded for each function in g_rc.c (parameter value is defined by colors.h header in libgeda).

This patch also changes the default light and dark color schemes so they work correctly with patched gschem.

Best regards
Tomaz

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=818428&aid=1885313&group_id=161080


_______________________________________________
geda-bug mailing list
geda-bug@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-bug