gEDA-bug: [Bug 698729] Re: spice-sdb -- Several fixes / Cleanups

[Peter TB Brett <peter@xxxxxxxxxxxxx>]

** Changed in: geda
       Status: Fix Released => Fix Committed

** Changed in: geda
   Importance: Undecided => Low

** Changed in: geda
     Assignee: (unassigned) => Peter TB Brett (peter-b)

** Changed in: geda
    Milestone: None => 1.7.0

-- 
You received this bug notification because you are a member of gEDA Bug
Team, which is subscribed to gEDA.
https://bugs.launchpad.net/bugs/698729

Title:
  spice-sdb -- Several fixes / Cleanups

Status in GPL Electronic Design Automation tools:
  Fix Committed

Bug description:
  Here is the patch set that i mentioned recently on geda-users along with my notes:

There is a bug related to the file attribute that seems to cause the variable "type" to be bound globally when a file is read in. This obscures another bug in write-ic and write-subcircuit where type is referenced but not localized. The value that the global type ended up with was something like "" and no one noticed when some symbols didn't have type set. In the process of adding a local copy I followed the advice in the comments that the two routines should be combined since they were virtual clones, so everything calls write-ic now.

There is another bug where get-package-attribute sometimes returns a "?" instead of "unknown" which I posted a fix for in patch # 3114991. One hunk removes the code snippet that dealt with this bug.

I did a general clean up to write-net-names-on-component that may make it more flexible. The code is about the same length when the debug statements are removed, though I had to add a couple of small utility routines.

I ran make tests and it passes.

    Ciao,
    Clif




_______________________________________________
geda-bug mailing list
geda-bug@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-bug