gEDA-bug: [Bug 700841] Re: gschem: during selection invisible attributes extend component bounding box

[Peter Clifton <pcjc2@xxxxxxxxx>]

Of course, your fix for patch No.3 contains some other code too.. such
as:

@@ -390,6 +396,7 @@ static void o_complex_remove_promotable_attribs (TOPLEVEL *toplevel, OBJECT *obj
     }
   }
 
+  o_bounds_invalidate (toplevel, object);
   g_list_free (promotable);
 }
 

See how easy that was to miss from my earlier review because of all the other changes, such as "o_is_invisible" etc..?
To be honest, I might even consider even making the o_is_invisible() getter, and o_set_visibility() changes separate patches.

-- 
You received this bug notification because you are a member of gEDA Bug
Team, which is subscribed to gEDA.
https://bugs.launchpad.net/bugs/700841

Title:
  gschem: during selection invisible attributes extend component bounding box 

Status in GPL Electronic Design Automation tools:
  In Progress

Bug description:
  Intermittently gschem gets into a state when promotable (visible) attributes within a component extend component's bounding box used for selection calculations.
In such cases component might not be selected even if selection rectangle encloses component's graphics and pins.
It is also possible to select the component by clicking on an empy space far away from it - because in the symbol file a visible attribute is located at that offset.

It is expected that components can be always selected by drawing a selection rectangle that encloses all graphical elements and pins.

When the bug occurs, toggling "show/hide invisible text" restores correct behavior.




_______________________________________________
geda-bug mailing list
geda-bug@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-bug