gEDA-bug: [Bug 700841] Re: gschem: during selection invisible attributes extend component bounding box

[Peter Clifton <pcjc2@xxxxxxxxx>]

Patches look excellent to me:

Reviewed-by: Peter Clifton <pcjc2@xxxxxxxxx>

I'm surprised that the getter / setter changes only affect libgeda
though, but in a way this is neater in some ways.

What I propose is that we push them for the stable-1.6 branch as is,
which will fix this bug.

There is still plenty of direct use of the object->visibility flag in
gschem and gattrib - It would be amazing if you could write us a follow-
up patch which applies on top of those you have already written, which:

1. Moves the getter and setters out of the libgeda private APIs, and into the exported API
2. Substitutes all use of the old API in gschem and gattrib

To ensure you catch all cases, what I would suggest is that you also
rename the member varibable from "visibility" to "_visibility". This
will be the last patch in the series after you have replaced all but the
legal usage in libgeda.

What I would do myself, is use "stgit", manage these pages:

1. Make a patch which exports the API
2. Make a patch which renames the member variable "visibility" to "_visibility", and fixes up its usage in the getter + setters (ONLY)
3. On top of this, make two more patches - one to use the setter, one to use the getter - in the other parts of the suite.
You know you're done when the whole suite compiles again ;)

Then I'd push those two patches, and "float" the rename patch (No. 2 to
the top. This way, the series should compile and work at every commit -
which is important.

Lets see - should we leave this bug open until all usage is converted, or should this be a new bug?
(New bug I think.. I'll start it off with this comment.

-- 
You received this bug notification because you are a member of gEDA Bug
Team, which is subscribed to gEDA.
https://bugs.launchpad.net/bugs/700841

Title:
  gschem: during selection invisible attributes extend component bounding box 

Status in GPL Electronic Design Automation tools:
  In Progress

Bug description:
  Intermittently gschem gets into a state when promotable (visible) attributes within a component extend component's bounding box used for selection calculations.
In such cases component might not be selected even if selection rectangle encloses component's graphics and pins.
It is also possible to select the component by clicking on an empy space far away from it - because in the symbol file a visible attribute is located at that offset.

It is expected that components can be always selected by drawing a selection rectangle that encloses all graphical elements and pins.

When the bug occurs, toggling "show/hide invisible text" restores correct behavior.




_______________________________________________
geda-bug mailing list
geda-bug@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-bug