gEDA-bug: [Bug 701431] Re: Export and use accessors for getting / setting object visibility

[Peter Clifton <pcjc2@xxxxxxxxx>]

Pushed, many thanks:

The branch, master has been updated
       via  c5a0980c4cd20ffaa32d24635ff92ae99f17bec9 (commit)
       via  183f9cc1aca8a850ea4f749f8be53934016d8ac4 (commit)
       via  4a9536ce1da2bc715d4d308fdb2ee2037a7efac3 (commit)
       via  43251b8588235a7594a07ff083fbd18e5501c6d1 (commit)
       via  5eef74de6e885d57df32617395cec3a012c9060b (commit)
       via  2a6c81e6b88e23b9f391c80b2c8a042cf5a87a1a (commit)
       via  0fad1e0c5aafa043387a8a5114795cdd352af3a6 (commit)
       via  97c5273a7ec9792a852f5193455a4c19ba6b6035 (commit)
      from  0f664b4c54ca3c38f31e169c642268091ae392f7 (commit)


** Changed in: geda
       Status: In Progress => Fix Committed

** Changed in: geda
     Assignee: Peter Clifton (pcjc2) => (unassigned)

-- 
You received this bug notification because you are a member of gEDA Bug
Team, which is subscribed to gEDA.
https://bugs.launchpad.net/bugs/701431

Title:
  Export and use accessors for getting / setting object visibility

Status in GPL Electronic Design Automation tools:
  Fix Committed

Bug description:
  Spilling this follow-up from bug 700841, the solution to which which
  introduces a libgeda private getter and setter for object visibility.

  Copying from my last comment there:

  I'm surprised that the getter / setter changes only affect libgeda
  though, but in a way this is neater in some ways.

  What I propose is that we push them for the stable-1.6 branch as is,
  which will fix this bug.

  There is still plenty of direct use of the object->visibility flag in
  gschem and gattrib - It would be amazing if you could write us a
  follow-up patch which applies on top of those you have already
  written, which:

  1. Moves the getter and setters out of the libgeda private APIs, and into the exported API
  2. Substitutes all use of the old API in gschem and gattrib

  To ensure you catch all cases, what I would suggest is that you also
  rename the member varibable from "visibility" to "_visibility". This
  will be the last patch in the series after you have replaced all but
  the legal usage in libgeda.

  What I would do myself, is use "stgit", manage these pages:

  1. Make a patch which exports the API
  2. Make a patch which renames the member variable "visibility" to "_visibility", and fixes up its usage in the getter + setters (ONLY)
  3. On top of this, make two more patches - one to use the setter, one to use the getter - in the other parts of the suite.
  You know you're done when the whole suite compiles again ;)

  Then I'd push those two patches, and "float" the rename patch (No. 2
  to the top. This way, the series should compile and work at every
  commit - which is important.

  Lets see - should we leave this bug open until all usage is converted, or should this be a new bug?
  (New bug I think.. I'll start it off with this comment.




_______________________________________________
geda-bug mailing list
geda-bug@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-bug