gEDA-bug: [Bug 699852] Re: Better keybindings for gschem "Select All" and "Deselect"

[Peter TB Brett <699852@xxxxxxxxxxxxxxxxxx>]

A few comments on the 2nd patch:

+      (lambda (kmap-entry)
+        (begin
+          (apply f (list kmap-entry))
+          (gschem:for-each-keymap f (eval-cm (cdr kmap-entry)))))

'begin' is unnecessary here ('lambda' has an implied 'begin').

+(define (select-sort less-than? L)

...

+           (sorted (select-sort string<? modifiers))

What's wrong with just using (sort modifiers string<?)? I'm not
convinced we need our own sorting algorithm implementation here...

** Changed in: geda
     Assignee: Peter TB Brett (peter-b) => Krzysztof KoÅciuszkiewicz (k-kosciuszkiewicz)

-- 
You received this bug notification because you are a member of gEDA Bug
Team, which is subscribed to gEDA.
https://bugs.launchpad.net/bugs/699852

Title:
  Better keybindings for gschem "Select All" and "Deselect"

Status in GPL Electronic Design Automation tools:
  In Progress

Bug description:
  gschem keybindings can only have a single modifier.  It's therefore not
  possible to give the "Edit->Select All" and "Edit->Deselect" actions the
  de facto standard <Ctrl-A> and <Ctrl-Shift-A> keybindings respectively
  (see also bug 699794 and bug 698865).

  An alternative pair of keybindings for these two actions that makes
  sense needs to be found.

   affects: geda
   milestone: 1.7.0
   importance: low
   tag gschem usability




_______________________________________________
geda-bug mailing list
geda-bug@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-bug