gEDA-bug: [Bug 698806] Re: Report bad component names.

[Peter TB Brett <698806@xxxxxxxxxxxxxxxxxx>]

commit eb2a355b688053d917dcb85981062451b27c5e8f
Author: Peter TB Brett <peter@xxxxxxxxxxxxx>
Date:   Mon Jan 24 08:37:46 2011 +0000

    gsch2pcb: Don't pass invalid function names to m4.
    
    This fixes a long-standing bug with gsch2pcb.  gsch2pcb expects
    `footprint' attributes to be of the form:
    
      footprint=NAME ARG1 ARG2
    
    This gets transformed to:
    
      PKG_NAME (`NAME-ARG1-ARG2',`refdes',`value',`ARG1',`ARG2')
    
    for macro-expansion by M4.  For this to work, it requires that NAME
    matches the regular expression ^[A-Za-z0-9_]$ so that PKG_NAME is a
    valid M4 function name.
    
    It is quite common for users (especially those using John Luciani's
    footprint library) to define and wish to use footprint names which
    contain hyphens '-'.  Since this character is not valid in M4 function
    names, this practice causes non-obvious breakage to occur.
    
    This patch stops gsch2pcb from ever attempting to macro-expand a
    footprint NAME which is obviously not valid as part of an M4 function
    name.
    
    Closes-bug: lp-698806


** Changed in: geda
       Status: Triaged => Fix Committed

** Changed in: geda
    Milestone: None => 1.7.1

-- 
You received this bug notification because you are a member of gEDA Bug
Team, which is subscribed to gEDA.
https://bugs.launchpad.net/bugs/698806

Title:
  Report bad component names.

Status in GPL Electronic Design Automation tools:
  Fix Committed

Bug description:
  If a component has a refdes with a dash in it, it will cause problems
  in PCB. A warning about this in gsch2pcb would be nice.




_______________________________________________
geda-bug mailing list
geda-bug@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-bug