[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

gEDA-bug: [Bug 708388] Re: Select all and deselect actions are too slow



GTK does not merge the rectangles, but it does optimise the inclusion
test.

In the attached patch I split the selection process into three steps:
1) collect matching objects in a list
2) compute & invalidate bounding box of the list
3) for each object - perform the selection & call registered hooks

In 3) some work is duplicated - o_invalidate is called for each object,
but GTK already saw one big invalidated rectangle so the cost is
negiligible.

For deselection a GList of affected objects is already available - see
above comment. This change is also included in the patch.

** Attachment added: "slow-select-lp-708388.tgz"
   https://bugs.launchpad.net/geda/+bug/708388/+attachment/1815989/+files/slow-select-lp-708388.tgz

** Changed in: geda
     Assignee: Krzysztof KoÅciuszkiewicz (k-kosciuszkiewicz) => Peter Clifton (pcjc2)

** Changed in: geda
       Status: New => In Progress

-- 
You received this bug notification because you are a member of gEDA Bug
Team, which is subscribed to gEDA.
https://bugs.launchpad.net/bugs/708388

Title:
  Select all and deselect actions are too slow

Status in GPL Electronic Design Automation tools:
  In Progress

Bug description:
  Select/deselect actions in gschem take up to 1 second on a moderately
  large schematic (900 lines in saved file).

  This is an annoyance and can hamper usability - the user can start
  repeating keystrokes or mouse clicks due to lack of feedback.




_______________________________________________
geda-bug mailing list
geda-bug@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-bug