gEDA-bug: [Bug 698741] Re: Problematic attribute place holder values

["gpleda.org commit robot" <698741@xxxxxxxxxxxxxxxxxx>]

Bug was fixed by a commit
git master commit d5d1a98f0e95589c33bff881198cca01a1b08c7e
http://git.gpleda.org/?p=gaf.git;a=commit;h=d5d1a98f0e95589c33bff881198cca01a1b08c7e

commit d5d1a98f0e95589c33bff881198cca01a1b08c7e
Author: Clif Cox <clif@xxxxxxxxxxxxx>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>

    Updated the problematic name attributes in some symbols
    
    In some gnetlist backends the name=? attributes cause problems because
    they look like valid attribute values. eg file=? may be mistaken for a
    valid filepath, and value=? for an actual value. Changing them to
    name=unknown is one way to solve this problem in the interim. It's now
    safe to remove the special checks for these "?" like the one in
    spice-sdb. This patch updates these problematic name=? attributes in
    some symbols to name=unknown, and removes FIXME code snipit that
    checked for the ? value in spice-sdb.
    
    It also updates gnetlist tests to reflect these changes. Turns out
    that the test input file TwoStageAmp.sch had a ? in it, which of couse
    caused problems.  Then when it was removed vams's output changed so it
    had to be fixed, which wasn't a very clever fix but seems to work.
    
    Closes-bug: lp-698741
    Reviewed-by: Peter TB Brett <peter@xxxxxxxxxxxxx>

** Changed in: geda
       Status: Triaged => Fix Committed

-- 
You received this bug notification because you are a member of gEDA Bug
Team, which is subscribed to gEDA.
https://bugs.launchpad.net/bugs/698741

Title:
  Problematic attribute place holder values

Status in GPL Electronic Design Automation tools:
  Fix Committed

Bug description:
  In some gnetlist backends the name=? attributes cause problems because they look like
  valid attribute values. eg file=? may be mistaken for a valid filepath, and value=? for 
  an actual value. Changing them to name=unknown is one way to solve this problem in the
  interim. It's now safe to remove the special checks for these "?" like the one in spice-sdb.
  This patch updates these problematic name=? attributes in some symbols to name=unknown,
  and removes FIXME code snipit that checked for the ? value in spice-sdb.

To manage notifications about this bug go to:
https://bugs.launchpad.net/geda/+bug/698741/+subscriptions


_______________________________________________
geda-bug mailing list
geda-bug@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-bug