[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

gEDA-bug: [ geda-Bugs-1815296 ] Non-existing schematic file not handled properly?



Bugs item #1815296, was opened at 2007-10-17 12:14
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=818426&aid=1815296&group_id=161080

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: libgeda
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Non-existing schematic file not handled properly?

Initial Comment:
In libgeda (1.2.0), f_basic.c around line 202, if the file doesn't exist then w_current->page_current->object_tail seems to be left uninitialised and the test on line 209 doesn't indicate that the file was not opened. Something like this may be better:
  
} else if (g_file_test (full_filename, G_FILE_TEST_EXISTS)) {
    /* Load the original file */
    w_current->page_current->object_tail = (OBJECT *) 
    o_read(w_current, w_current->page_current->object_tail, 
	   full_filename);
/* added the following: */
  } else w_current->page_current->object_tail = NULL;

gnetlist currently gives no error message if invoked with a schematic file that can't be found. The above fix results in gnetlist giving an appropriate message.

peter.baxendale@xxxxxxxxxxxx

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=818426&aid=1815296&group_id=161080


_______________________________________________
geda-bug mailing list
geda-bug@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-bug