[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
gEDA-cvs: CVS update: f_image.c
User: pcjc2
Date: 07/04/12 14:43:10
Modified: . Tag: noscreen f_image.c f_print.c g_smob.c
o_complex_basic.c o_pin_basic.c
Log:
Fixed a number of mis-uses of world_get_complex_bounds(). A grep shows no more remain.
Revision Changes Path
No revision
No revision
1.19.6.1 +4 -4 eda/geda/gaf/libgeda/src/f_image.c
(In the diff below, changes in quantity of whitespace are not shown.)
Index: f_image.c
===================================================================
RCS file: /home/cvspsrv/cvsroot/eda/geda/gaf/libgeda/src/f_image.c,v
retrieving revision 1.19
retrieving revision 1.19.6.1
diff -u -b -r1.19 -r1.19.6.1
--- f_image.c 22 Sep 2006 18:48:07 -0000 1.19
+++ f_image.c 12 Apr 2007 18:43:09 -0000 1.19.6.1
@@ -187,7 +187,7 @@
/* printf("%d %d\n", w_current->paper_width, w_current->paper_height);*/
- world_get_complex_bounds(w_current,
+ world_get_object_list_bounds(w_current,
w_current->page_current->object_head,
&origin_x, &origin_y,
&right, &bottom);
1.25.6.2 +4 -4 eda/geda/gaf/libgeda/src/f_print.c
(In the diff below, changes in quantity of whitespace are not shown.)
Index: f_print.c
===================================================================
RCS file: /home/cvspsrv/cvsroot/eda/geda/gaf/libgeda/src/f_print.c,v
retrieving revision 1.25.6.1
retrieving revision 1.25.6.2
diff -u -b -r1.25.6.1 -r1.25.6.2
--- f_print.c 11 Feb 2007 23:59:03 -0000 1.25.6.1
+++ f_print.c 12 Apr 2007 18:43:09 -0000 1.25.6.2
@@ -443,7 +443,7 @@
/* printf("%d %d\n", w_current->paper_width, w_current->paper_height);*/
- world_get_complex_bounds(w_current,
+ world_get_object_list_bounds(w_current,
w_current->page_current->object_head,
&origin_x, &origin_y,
&right, &bottom);
1.11.2.3 +7 -5 eda/geda/gaf/libgeda/src/g_smob.c
(In the diff below, changes in quantity of whitespace are not shown.)
Index: g_smob.c
===================================================================
RCS file: /home/cvspsrv/cvsroot/eda/geda/gaf/libgeda/src/g_smob.c,v
retrieving revision 1.11.2.2
retrieving revision 1.11.2.3
diff -u -b -r1.11.2.2 -r1.11.2.3
--- g_smob.c 6 Apr 2007 17:29:14 -0000 1.11.2.2
+++ g_smob.c 12 Apr 2007 18:43:09 -0000 1.11.2.3
@@ -377,8 +377,10 @@
/*! \brief Get the bounds of an attribute.
* \par Function Description
* Get the bounds of an attribute.
- * I got top and bottom values reversed from world_get_complex_bounds,
- * so don\'t rely on the position in the list.
+ * WARNING: top and bottom are mis-named in world-coords,
+ * top is the smallest "y" value, and bottom is the largest.
+ * Be careful! This doesn't correspond to what you'd expect,
+ * nor to the coordinate system who's origin is the bottom, left of the page.
* \param[in] attrib_smob the attribute.
* \return a list of the bounds of the <B>attrib smob</B>.
* The list has the format: ( (left right) (top bottom) )
1.30.2.6 +1 -1 eda/geda/gaf/libgeda/src/o_complex_basic.c
(In the diff below, changes in quantity of whitespace are not shown.)
Index: o_complex_basic.c
===================================================================
RCS file: /home/cvspsrv/cvsroot/eda/geda/gaf/libgeda/src/o_complex_basic.c,v
retrieving revision 1.30.2.5
retrieving revision 1.30.2.6
diff -u -b -r1.30.2.5 -r1.30.2.6
--- o_complex_basic.c 24 Mar 2007 02:50:34 -0000 1.30.2.5
+++ o_complex_basic.c 12 Apr 2007 18:43:09 -0000 1.30.2.6
@@ -689,7 +689,7 @@
if ((!o_current) || (o_current->type != OBJ_COMPLEX && o_current->type != OBJ_PLACEHOLDER))
return;
- world_get_object_list_bounds(w_current, o_current->complex->prim_objs, &left, &top, &right, &bottom);
+ world_get_complex_bounds(w_current, o_current, &left, &top, &right, &bottom);
o_current->w_left = left;
o_current->w_top = top;
o_current->w_right = right;
1.24.2.10 +2 -2 eda/geda/gaf/libgeda/src/o_pin_basic.c
(In the diff below, changes in quantity of whitespace are not shown.)
Index: o_pin_basic.c
===================================================================
RCS file: /home/cvspsrv/cvsroot/eda/geda/gaf/libgeda/src/o_pin_basic.c,v
retrieving revision 1.24.2.9
retrieving revision 1.24.2.10
diff -u -b -r1.24.2.9 -r1.24.2.10
--- o_pin_basic.c 26 Mar 2007 19:16:12 -0000 1.24.2.9
+++ o_pin_basic.c 12 Apr 2007 18:43:09 -0000 1.24.2.10
@@ -479,7 +479,7 @@
if (object_list && num_pins) {
if (num_pins == 1 || w_current->force_boundingbox) {
- world_get_complex_bounds(w_current, object_list,
+ world_get_object_list_bounds(w_current, object_list,
&left, &top, &right, &bottom);
} else {
found = 0;
_______________________________________________
geda-cvs mailing list
geda-cvs@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-cvs