[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
gEDA-cvs: branch: master updated (1.4.0-20080127-43-gb4aade6)
The branch, master has been updated
via b4aade65f2488b4a7fd74f34a90225c0da7ec9f3 (commit)
via e089678b9fc068a4b14f41a47e7cef304d5d8221 (commit)
via 949ebc253254a4ec4798ea5faab6bce698fabbb0 (commit)
via f1754277410f7e42fa86371ff875dbbf9f5dd100 (commit)
from 7db9237c6e382a81fd5e536bbab8b4a8c78650b1 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
=========
Summary
=========
gattrib/src/gattrib.c | 4 ++--
gschem/include/globals.h | 1 -
gschem/src/globals.c | 1 -
gschem/src/gschem.c | 6 +-----
gschem/src/x_window.c | 4 +++-
libgeda/include/prototype.h | 1 -
libgeda/src/i_vars.c | 19 -------------------
7 files changed, 6 insertions(+), 30 deletions(-)
=================
Commit Messages
=================
commit b4aade65f2488b4a7fd74f34a90225c0da7ec9f3
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Date: Fri Apr 18 14:11:07 2008 +0100
libgeda: Remove unused function i_vars_setnames
:100644 100644 49e3236... 23326e2... M libgeda/include/prototype.h
:100644 100644 33275f5... 507714f... M libgeda/src/i_vars.c
commit e089678b9fc068a4b14f41a47e7cef304d5d8221
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Date: Fri Apr 18 14:11:06 2008 +0100
gschem: Fix memory leak in x_window_open_page()
:100644 100644 4a1a4c6... 1c8ec6e... M gschem/src/x_window.c
commit 949ebc253254a4ec4798ea5faab6bce698fabbb0
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Date: Thu Apr 17 21:55:09 2008 +0100
gschem: Use argc, rather than relying that char **argv is NULL terminated
:100644 100644 9fcccee... c3bdd49... M gattrib/src/gattrib.c
:100644 100644 42bf94e... 4e2e632... M gschem/src/gschem.c
commit f1754277410f7e42fa86371ff875dbbf9f5dd100
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Date: Thu Apr 17 20:00:30 2008 +0100
gschem: Remove unused GDK global variable "visual"
:100644 100644 ddc5720... 6b0ee77... M gschem/include/globals.h
:100644 100644 23644d7... 858468a... M gschem/src/globals.c
:100644 100644 5c9b6db... 42bf94e... M gschem/src/gschem.c
=========
Changes
=========
commit b4aade65f2488b4a7fd74f34a90225c0da7ec9f3
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Date: Fri Apr 18 14:11:07 2008 +0100
libgeda: Remove unused function i_vars_setnames
diff --git a/libgeda/include/prototype.h b/libgeda/include/prototype.h
index 49e3236..23326e2 100644
--- a/libgeda/include/prototype.h
+++ b/libgeda/include/prototype.h
@@ -58,7 +58,6 @@ gboolean g_get_data_from_page_smob(SCM object_smob, TOPLEVEL **toplevel,
/* i_vars.c */
void i_vars_libgeda_set(TOPLEVEL *toplevel);
-void i_vars_setnames(TOPLEVEL *toplevel);
void i_vars_freenames();
/* gdk-pixbuf-hacks.c */
diff --git a/libgeda/src/i_vars.c b/libgeda/src/i_vars.c
index 33275f5..507714f 100644
--- a/libgeda/src/i_vars.c
+++ b/libgeda/src/i_vars.c
@@ -95,25 +95,6 @@ void i_vars_libgeda_set(TOPLEVEL *toplevel)
}
-/*! \brief Set all names in TOPLEVEL object to default.
- * \par Function Description
- * This function will set all of the names in the TOPLEVEL toplevel variable
- * to their default.
- *
- * \param [out] toplevel The TOPLEVEL object to set to defaults.
- *
- */
-void i_vars_setnames(TOPLEVEL *toplevel)
-{
- toplevel->series_name = g_strdup (DEFAULT_SERIES_NAME );
- toplevel->untitled_name = g_strdup (DEFAULT_UNTITLED_NAME );
- toplevel->font_directory = g_strdup (DEFAULT_FONT_DIRECTORY );
- toplevel->scheme_directory = g_strdup (DEFAULT_SCHEME_DIRECTORY);
- toplevel->bitmap_directory = g_strdup (DEFAULT_BITMAP_DIRECTORY);
- toplevel->bus_ripper_symname = g_strdup (DEFAULT_BUS_RIPPER_SYMNAME);
- toplevel->always_promote_attributes = g_strdup (DEFAULT_ALWAYS_PROMOTE_ATTRIBUTES);
- toplevel->print_command = g_strdup (DEFAULT_PRINT_COMMAND);
-}
/*! \brief Free default names
* \par Function Description
commit e089678b9fc068a4b14f41a47e7cef304d5d8221
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Date: Fri Apr 18 14:11:06 2008 +0100
gschem: Fix memory leak in x_window_open_page()
diff --git a/gschem/src/x_window.c b/gschem/src/x_window.c
index 4a1a4c6..1c8ec6e 100644
--- a/gschem/src/x_window.c
+++ b/gschem/src/x_window.c
@@ -795,8 +795,10 @@ x_window_open_page (GSCHEM_TOPLEVEL *w_current, const gchar *filename)
/* Return existing page if it is already loaded */
page = s_page_search (toplevel, fn);
- if ( page != NULL )
+ if ( page != NULL ) {
+ g_free(fn);
return page;
+ }
old_current = toplevel->page_current;
page = s_page_new (toplevel, fn);
commit 949ebc253254a4ec4798ea5faab6bce698fabbb0
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Date: Thu Apr 17 21:55:09 2008 +0100
gschem: Use argc, rather than relying that char **argv is NULL terminated
diff --git a/gattrib/src/gattrib.c b/gattrib/src/gattrib.c
index 9fcccee..c3bdd49 100644
--- a/gattrib/src/gattrib.c
+++ b/gattrib/src/gattrib.c
@@ -191,7 +191,7 @@ void gattrib_main(void *closure, int argc, char *argv[])
sheet_head = s_sheet_data_new(); /* sheet_head was declared in globals.h */
GSList *file_list = NULL;
- if(argv[argv_index] == NULL) {
+ if (argv_index >= argc) {
/* No files specified on the command line, pop up the File open dialog. */
file_list = x_fileselect_open();
if(file_list == NULL)
@@ -199,7 +199,7 @@ void gattrib_main(void *closure, int argc, char *argv[])
} else {
/* Construct the list of filenames from the command line.
* argv_index holds the position of the first filename */
- while(argv[argv_index] != NULL) {
+ while (argv_index < argc) {
file_list = g_slist_append(file_list, f_normalize_filename(argv[argv_index]));
argv_index++;
}
diff --git a/gschem/src/gschem.c b/gschem/src/gschem.c
index 42bf94e..4e2e632 100644
--- a/gschem/src/gschem.c
+++ b/gschem/src/gschem.c
@@ -275,8 +275,7 @@ void main_prog(void *closure, int argc, char *argv[])
x_repaint_background (w_current);
w_current->grid = save_grid;
- i = argv_index;
- while (argv[i] != NULL) {
+ for (i = argv_index; i < argc; i++) {
if (g_path_is_absolute(argv[i]))
{
@@ -296,8 +295,6 @@ void main_prog(void *closure, int argc, char *argv[])
*/
x_window_open_page(w_current, filename);
- /* Go to the next argument */
- i++;
}
free(cwd); /* allocated from getcwd, should be regular free */
commit f1754277410f7e42fa86371ff875dbbf9f5dd100
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Date: Thu Apr 17 20:00:30 2008 +0100
gschem: Remove unused GDK global variable "visual"
diff --git a/gschem/include/globals.h b/gschem/include/globals.h
index ddc5720..6b0ee77 100644
--- a/gschem/include/globals.h
+++ b/gschem/include/globals.h
@@ -26,7 +26,6 @@ extern GList *global_window_list;
/* color stuff */
extern GdkColormap *colormap;
-extern GdkVisual *visual;
/* colors */
extern GdkColor white;
diff --git a/gschem/src/globals.c b/gschem/src/globals.c
index 23644d7..858468a 100644
--- a/gschem/src/globals.c
+++ b/gschem/src/globals.c
@@ -46,7 +46,6 @@ char *output_filename = NULL;
/* color stuff */
GdkColormap *colormap;
-GdkVisual *visual;
/* colors */
GdkColor white;
diff --git a/gschem/src/gschem.c b/gschem/src/gschem.c
index 5c9b6db..42bf94e 100644
--- a/gschem/src/gschem.c
+++ b/gschem/src/gschem.c
@@ -165,7 +165,6 @@ void main_prog(void *closure, int argc, char *argv[])
#endif
gtk_init(&argc, &argv);
- visual = gdk_visual_get_system();
argv_index = parse_commandline(argc, argv);
cwd = getcwd(NULL, 1024);
_______________________________________________
geda-cvs mailing list
geda-cvs@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-cvs