[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

gEDA-cvs: pcb.git: branch: master updated (d8fef462f5c3608ab2c11f13ffc5135a312c10e0)



The branch, master has been updated
       via  d8fef462f5c3608ab2c11f13ffc5135a312c10e0 (commit)
       via  3ba0473b72c74a8d65f00078759f3340b01c1701 (commit)
      from  c0786a1526e34a23f8c1db4eafd25e8c2ed8de34 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


=========
 Summary
=========

 src/hid/common/draw_helpers.c |   21 +++++++++++++--------
 src/hid/gcode/gcode.c         |    2 ++
 src/hid/png/png.c             |    2 ++
 3 files changed, 17 insertions(+), 8 deletions(-)


=================
 Commit Messages
=================

commit d8fef462f5c3608ab2c11f13ffc5135a312c10e0
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Commit: Peter Clifton <pcjc2@xxxxxxxxx>

    hid/common: Some formatting changes in draw_helpers.c

:100644 100644 dc1f60f... b9db654... M	src/hid/common/draw_helpers.c

commit 3ba0473b72c74a8d65f00078759f3340b01c1701
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Commit: Peter Clifton <pcjc2@xxxxxxxxx>

    Add missing HID structure zero initialisation for gcode and png HIDs.
    
    Missed from commit commit d67f4335b5d4f97330448b833ea1bf04377c3a57
    
      "Initialise the HID vtable by function, rather than as a struct initialiser."
    
    I missed the memset from these two HIDs.

:100644 100644 9360cb7... 3e49ed3... M	src/hid/gcode/gcode.c
:100644 100644 ca87a84... 7c2f461... M	src/hid/png/png.c

=========
 Changes
=========

commit d8fef462f5c3608ab2c11f13ffc5135a312c10e0
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Commit: Peter Clifton <pcjc2@xxxxxxxxx>

    hid/common: Some formatting changes in draw_helpers.c

diff --git a/src/hid/common/draw_helpers.c b/src/hid/common/draw_helpers.c
index dc1f60f..b9db654 100644
--- a/src/hid/common/draw_helpers.c
+++ b/src/hid/common/draw_helpers.c
@@ -2,7 +2,8 @@
 #include "hid.h"
 #include "polygon.h"
 
-static void fill_contour (hidGC gc, PLINE *pl)
+static void
+fill_contour (hidGC gc, PLINE *pl)
 {
   int *x, *y, n, i = 0;
   VNODE *v;
@@ -23,7 +24,8 @@ static void fill_contour (hidGC gc, PLINE *pl)
   free (y);
 }
 
-static void thindraw_contour (hidGC gc, PLINE *pl)
+static void
+thindraw_contour (hidGC gc, PLINE *pl)
 {
   VNODE *v;
   int last_x, last_y;
@@ -61,7 +63,8 @@ static void thindraw_contour (hidGC gc, PLINE *pl)
   while ((v = v->next) != pl->head.next);
 }
 
-static void fill_contour_cb (PLINE *pl, void *user_data)
+static void
+fill_contour_cb (PLINE *pl, void *user_data)
 {
   hidGC gc = (hidGC)user_data;
   PLINE *local_pl = pl;
@@ -136,8 +139,8 @@ should_compute_no_holes (PolygonType *poly, const BoxType *clip_box)
 }
 #undef BOUNDS_INSIDE_CLIP_THRESHOLD
 
-void common_fill_pcb_polygon (hidGC gc, PolygonType *poly,
-                              const BoxType *clip_box)
+void
+common_fill_pcb_polygon (hidGC gc, PolygonType *poly, const BoxType *clip_box)
 {
   /* FIXME: We aren't checking the gui's dicer flag..
             we are dicing for every case. Some GUIs
@@ -180,15 +183,17 @@ void common_fill_pcb_polygon (hidGC gc, PolygonType *poly,
     }
 }
 
-static int thindraw_hole_cb (PLINE *pl, void *user_data)
+static int
+thindraw_hole_cb (PLINE *pl, void *user_data)
 {
   hidGC gc = (hidGC)user_data;
   thindraw_contour (gc, pl);
   return 0;
 }
 
-void common_thindraw_pcb_polygon (hidGC gc, PolygonType *poly,
-                                  const BoxType *clip_box)
+void
+common_thindraw_pcb_polygon (hidGC gc, PolygonType *poly,
+                             const BoxType *clip_box)
 {
   thindraw_contour (gc, poly->Clipped->contours);
   PolygonHoles (poly, clip_box, thindraw_hole_cb, gc);

commit 3ba0473b72c74a8d65f00078759f3340b01c1701
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Commit: Peter Clifton <pcjc2@xxxxxxxxx>

    Add missing HID structure zero initialisation for gcode and png HIDs.
    
    Missed from commit commit d67f4335b5d4f97330448b833ea1bf04377c3a57
    
      "Initialise the HID vtable by function, rather than as a struct initialiser."
    
    I missed the memset from these two HIDs.

diff --git a/src/hid/gcode/gcode.c b/src/hid/gcode/gcode.c
index 9360cb7..3e49ed3 100644
--- a/src/hid/gcode/gcode.c
+++ b/src/hid/gcode/gcode.c
@@ -1035,6 +1035,8 @@ HID gcode_hid;
 void
 hid_gcode_init ()
 {
+  memset (&gcode_hid, 0, sizeof (HID));
+
   gcode_hid.struct_size         = sizeof (HID);
   gcode_hid.name                = "gcode";
   gcode_hid.description         = "G-CODE export.";
diff --git a/src/hid/png/png.c b/src/hid/png/png.c
index ca87a84..7c2f461 100644
--- a/src/hid/png/png.c
+++ b/src/hid/png/png.c
@@ -1519,6 +1519,8 @@ png_set_crosshair (int x, int y, int a)
 void
 hid_png_init ()
 {
+  memset (&png_hid, 0, sizeof (HID));
+
   png_hid.struct_size = sizeof (HID);
   png_hid.name        = "png";
   png_hid.description = "GIF/JPEG/PNG export.";




_______________________________________________
geda-cvs mailing list
geda-cvs@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-cvs