[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

gEDA-cvs: pcb.git: branch: master updated (cf1a2e2aaff6fc60f2a7243f8e456f8605d1b55a)



The branch, master has been updated
  discards  831d4889e7daef86552448bf6004abb14370d4e3 (commit)
       via  cf1a2e2aaff6fc60f2a7243f8e456f8605d1b55a (commit)
      from  831d4889e7daef86552448bf6004abb14370d4e3 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


=========
 Summary
=========



=================
 Commit Messages
=================

commit cf1a2e2aaff6fc60f2a7243f8e456f8605d1b55a
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Commit: Peter Clifton <pcjc2@xxxxxxxxx>

    Revert "Fix potential segfault"
    
    This reverts commit 2d2040e92d5ebb069af42567855055b096532e71.
    
    This patch causes segfaults in the GTK and Lesstif hids, so reverting,
    as it removes the required NULL termination from an attribute
    enumeration. Any code which can't deal with an empty enumeration list
    should be fixed instead.
    
    Reopens-bug: lp-699290 (sf-2669324)
    Closes-bug: lp-769336

:100644 100644 3919a6e... 274741d... M	src/hid/png/png.c

=========
 Changes
=========

commit cf1a2e2aaff6fc60f2a7243f8e456f8605d1b55a
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Commit: Peter Clifton <pcjc2@xxxxxxxxx>

    Revert "Fix potential segfault"
    
    This reverts commit 2d2040e92d5ebb069af42567855055b096532e71.
    
    This patch causes segfaults in the GTK and Lesstif hids, so reverting,
    as it removes the required NULL termination from an attribute
    enumeration. Any code which can't deal with an empty enumeration list
    should be fixed instead.
    
    Reopens-bug: lp-699290 (sf-2669324)
    Closes-bug: lp-769336

diff --git a/src/hid/png/png.c b/src/hid/png/png.c
index 3919a6e..274741d 100644
--- a/src/hid/png/png.c
+++ b/src/hid/png/png.c
@@ -148,7 +148,7 @@ static const char *filetypes[] = {
   FMT_jpg,
 #endif
 
-  ""
+  NULL
 };
 
 HID_Attribute png_attribute_list[] = {




_______________________________________________
geda-cvs mailing list
geda-cvs@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-cvs