gEDA-cvs: pcb.git: branch: master updated (86356b85ea41672e0e84e9b07e4e0fe7950190b8)

[git@xxxxxxxxxx]

The branch, master has been updated
       via  86356b85ea41672e0e84e9b07e4e0fe7950190b8 (commit)
       via  c095adf5ea890284cddc2730944b980ac1275109 (commit)
      from  cbd7c001aa130c53bf04396d347b32f9d6bb9034 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


=========
 Summary
=========

 src/draw.c |   21 ++++++---------------
 1 files changed, 6 insertions(+), 15 deletions(-)


=================
 Commit Messages
=================

commit 86356b85ea41672e0e84e9b07e4e0fe7950190b8
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Commit: Peter Clifton <pcjc2@xxxxxxxxx>

    draw.c: Remove  a couple of redundant if statements
    
    The outer if statement already ensures this code-path isn't followed for
    a gui hid.. don't repeat ourselves. One statement will always return
    false, hence is dead code - the other is always true.

:100644 100644 f204fdc... 9f7cf8b... M	src/draw.c

commit c095adf5ea890284cddc2730944b980ac1275109
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Commit: Peter Clifton <pcjc2@xxxxxxxxx>

    draw.c: Use the via callback when drawing vias.
    
    Since this code-path is only hit for exporters, (and the only difference
    between the pin and via callback is the drawing colour) it is not likely
    this matters, but lets be correct.

:100644 100644 8178e81... f204fdc... M	src/draw.c

=========
 Changes
=========

commit 86356b85ea41672e0e84e9b07e4e0fe7950190b8
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Commit: Peter Clifton <pcjc2@xxxxxxxxx>

    draw.c: Remove  a couple of redundant if statements
    
    The outer if statement already ensures this code-path isn't followed for
    a gui hid.. don't repeat ourselves. One statement will always return
    false, hence is dead code - the other is always true.

diff --git a/src/draw.c b/src/draw.c
index f204fdc..9f7cf8b 100644
--- a/src/draw.c
+++ b/src/draw.c
@@ -382,12 +382,8 @@ DrawEverything (BoxTypePtr drawn_area)
 	{
 	  if (DrawLayerGroup (group, drawn_area) && !gui->gui)
 	    {
-	      if (TEST_FLAG (CHECKPLANESFLAG, PCB) && gui->gui)
-		continue;
-	      r_search (PCB->Data->pin_tree, drawn_area, NULL, pin_callback,
-			NULL);
-	      r_search (PCB->Data->via_tree, drawn_area, NULL, via_callback,
-			NULL);
+	      r_search (PCB->Data->pin_tree, drawn_area, NULL, pin_callback, NULL);
+	      r_search (PCB->Data->via_tree, drawn_area, NULL, via_callback, NULL);
 	      /* draw element pads */
 	      if (group == component || group == solder)
 		{
@@ -395,15 +391,10 @@ DrawEverything (BoxTypePtr drawn_area)
 		  r_search (PCB->Data->pad_tree, drawn_area, NULL, pad_callback, &side);
 		}
 
-	      if (!gui->gui)
-		{
-		  /* draw holes */
-		  plated = -1;
-		  r_search (PCB->Data->pin_tree, drawn_area, NULL, hole_callback,
-			    &plated);
-		  r_search (PCB->Data->via_tree, drawn_area, NULL, hole_callback,
-			    &plated);
-		}
+	      /* draw holes */
+	      plated = -1;
+	      r_search (PCB->Data->pin_tree, drawn_area, NULL, hole_callback, &plated);
+	      r_search (PCB->Data->via_tree, drawn_area, NULL, hole_callback, &plated);
 	    }
 	}
     }

commit c095adf5ea890284cddc2730944b980ac1275109
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Commit: Peter Clifton <pcjc2@xxxxxxxxx>

    draw.c: Use the via callback when drawing vias.
    
    Since this code-path is only hit for exporters, (and the only difference
    between the pin and via callback is the drawing colour) it is not likely
    this matters, but lets be correct.

diff --git a/src/draw.c b/src/draw.c
index 8178e81..f204fdc 100644
--- a/src/draw.c
+++ b/src/draw.c
@@ -386,7 +386,7 @@ DrawEverything (BoxTypePtr drawn_area)
 		continue;
 	      r_search (PCB->Data->pin_tree, drawn_area, NULL, pin_callback,
 			NULL);
-	      r_search (PCB->Data->via_tree, drawn_area, NULL, pin_callback,
+	      r_search (PCB->Data->via_tree, drawn_area, NULL, via_callback,
 			NULL);
 	      /* draw element pads */
 	      if (group == component || group == solder)




_______________________________________________
geda-cvs mailing list
geda-cvs@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-cvs